renaming removeFrom to remove #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change renames the 'removeFrom' function to 'remove' keeping this plugin inline with the standard leaflet control. See here for information on when leaflet changed their controls removal function from `removeFrom` to just `remove`: Leaflet/Leaflet@eec19a4
|
we should at least deprecate it before removing it. removing it requires a major version bump. |
Added depreciation warning that indicates that the function will be removed in a later version.
|
I added a warning that the function will be depreciated in a future version, the warning is only shown when the removeFrom() function is called. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change renames the
removeFromfunction toremovekeeping this plugin inline leaflet.See here for information on when leaflet changed their controls removal function from
removeFromto justremove: Leaflet/Leaflet@eec19a4